dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat(otel): enable otel support by default

Open mabdinur opened this issue 2 years ago • 1 comments
trafficstars

Checklist

  • [x] Change(s) are motivated and described in the PR description.
  • [x] Testing strategy is described if automated tests are not included in the PR.
  • [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • [x] Change is maintainable (easy to change, telemetry, documentation).
  • [x] Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • [x] Documentation is included (in-code, generated user docs, public corp docs).
  • [x] Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] No unnecessary changes are introduced.
  • [ ] Description motivates each change.
  • [ ] Avoids breaking API changes unless absolutely necessary.
  • [ ] Testing strategy adequately addresses listed risk(s).
  • [ ] Change is maintainable (easy to change, telemetry, documentation).
  • [ ] Release note makes sense to a user of the library.
  • [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • [ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • [ ] This PR doesn't touch any of that.

mabdinur avatar Sep 27 '23 16:09 mabdinur

Benchmarks

Benchmark execution time: 2023-10-02 20:25:42

Comparing candidate commit 0a949c13be0fa85ae38bc8f77bc07be5ff3d8ca4 in PR branch munir/enable-otel-support-by-default with baseline commit 06ec84635ed3dc9eb263b17c795e6f29fc5d864e in branch 2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 0 unstable metrics.

pr-commenter[bot] avatar Sep 27 '23 17:09 pr-commenter[bot]