dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

demo

Open tabgok opened this issue 1 year ago • 1 comments

Checklist

  • [ ] Change(s) are motivated and described in the PR description.
  • [ ] Testing strategy is described if automated tests are not included in the PR.
  • [ ] Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • [ ] Change is maintainable (easy to change, telemetry, documentation).
  • [ ] Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • [ ] Documentation is included (in-code, generated user docs, public corp docs).
  • [ ] Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] No unnecessary changes are introduced.
  • [ ] Description motivates each change.
  • [ ] Avoids breaking API changes unless absolutely necessary.
  • [ ] Testing strategy adequately addresses listed risk(s).
  • [ ] Change is maintainable (easy to change, telemetry, documentation).
  • [ ] Release note makes sense to a user of the library.
  • [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

tabgok avatar Jul 27 '23 21:07 tabgok

Benchmarks

Benchmark execution time: 2023-08-30 15:27:35

Comparing candidate commit 4419b97ae9b166b6ac08cd2e696cefbd0138409b in PR branch teague.bick/context-api/testground with baseline commit 35b96249ca585b9551a08e01f40f7eb2c9e2e655 in branch 1.x.

Found 1 performance improvements and 45 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:flasksimple-appsec-get

  • 🟥 max_rss_usage [+3.077MB; +3.273MB] or [+9.017%; +9.592%]

scenario:flasksimple-appsec-post

  • 🟥 max_rss_usage [+3.223MB; +3.415MB] or [+9.444%; +10.007%]

scenario:flasksimple-appsec-telemetry

  • 🟥 max_rss_usage [+3.697MB; +3.864MB] or [+10.835%; +11.322%]

scenario:flasksimple-baseline

  • 🟥 max_rss_usage [+3.652MB; +3.842MB] or [+10.699%; +11.253%]

scenario:flasksimple-debugger

  • 🟥 max_rss_usage [+3.691MB; +3.906MB] or [+10.832%; +11.463%]

scenario:flasksimple-iast-get

  • 🟥 max_rss_usage [+3.734MB; +3.915MB] or [+10.948%; +11.479%]

scenario:flasksimple-profiler

  • 🟥 max_rss_usage [+3.707MB; +3.860MB] or [+10.858%; +11.306%]

scenario:flasksimple-tracer

  • 🟥 max_rss_usage [+3.653MB; +3.850MB] or [+10.699%; +11.277%]

scenario:iastpropagation-no-propagation

  • 🟥 max_rss_usage [+2.261MB; +2.387MB] or [+6.965%; +7.352%]

scenario:iastpropagation-propagation_enabled_100

  • 🟩 max_rss_usage [-186.046MB; -185.827MB] or [-45.819%; -45.764%]

scenario:otelspan-add-metrics

  • 🟥 max_rss_usage [+3.955MB; +4.130MB] or [+9.705%; +10.137%]

scenario:otelspan-add-tags

  • 🟥 max_rss_usage [+3.961MB; +4.105MB] or [+9.702%; +10.053%]

scenario:otelspan-start

  • 🟥 max_rss_usage [+2.133MB; +2.301MB] or [+4.442%; +4.792%]

scenario:otelspan-start-finish

  • 🟥 max_rss_usage [+2.696MB; +2.822MB] or [+9.366%; +9.804%]

scenario:otelspan-start-finish-telemetry

  • 🟥 max_rss_usage [+2.600MB; +2.724MB] or [+8.928%; +9.353%]

scenario:samplingrules-average_match

  • 🟥 max_rss_usage [+2.235MB; +2.344MB] or [+8.096%; +8.488%]

scenario:samplingrules-high_match

  • 🟥 max_rss_usage [+2.197MB; +2.305MB] or [+7.948%; +8.338%]

scenario:samplingrules-low_match

  • 🟥 max_rss_usage [+2.924MB; +3.020MB] or [+10.249%; +10.587%]

scenario:samplingrules-very_low_match

  • 🟥 max_rss_usage [+2.683MB; +2.811MB] or [+6.204%; +6.502%]

scenario:sethttpmeta-all-disabled

  • 🟥 max_rss_usage [+2.515MB; +2.676MB] or [+8.969%; +9.543%]

scenario:sethttpmeta-all-enabled

  • 🟥 max_rss_usage [+2.604MB; +2.749MB] or [+9.294%; +9.809%]

scenario:sethttpmeta-collectipvariant_exists

  • 🟥 max_rss_usage [+2.469MB; +2.622MB] or [+8.581%; +9.112%]

scenario:sethttpmeta-no-collectipvariant

  • 🟥 max_rss_usage [+2.569MB; +2.713MB] or [+9.180%; +9.693%]

scenario:sethttpmeta-no-useragentvariant

  • 🟥 max_rss_usage [+2.514MB; +2.659MB] or [+8.742%; +9.244%]

scenario:sethttpmeta-obfuscation-disabled

  • 🟥 max_rss_usage [+2.566MB; +2.710MB] or [+8.920%; +9.421%]

scenario:sethttpmeta-obfuscation-no-query

  • 🟥 max_rss_usage [+2.588MB; +2.720MB] or [+9.235%; +9.706%]

scenario:sethttpmeta-obfuscation-regular-case-explicit-query

  • 🟥 max_rss_usage [+2.592MB; +2.736MB] or [+8.955%; +9.453%]

scenario:sethttpmeta-obfuscation-regular-case-implicit-query

  • 🟥 max_rss_usage [+2.498MB; +2.656MB] or [+8.644%; +9.192%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟥 max_rss_usage [+2.575MB; +2.695MB] or [+8.890%; +9.305%]

scenario:sethttpmeta-obfuscation-worst-case-explicit-query

  • 🟥 max_rss_usage [+2.531MB; +2.689MB] or [+8.727%; +9.272%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟥 max_rss_usage [+2.643MB; +2.780MB] or [+9.134%; +9.607%]

scenario:sethttpmeta-useragentvariant_exists_1

  • 🟥 max_rss_usage [+2.543MB; +2.712MB] or [+8.859%; +9.445%]

scenario:sethttpmeta-useragentvariant_exists_2

  • 🟥 max_rss_usage [+2.530MB; +2.696MB] or [+8.808%; +9.388%]

scenario:sethttpmeta-useragentvariant_exists_3

  • 🟥 max_rss_usage [+2.600MB; +2.755MB] or [+9.060%; +9.601%]

scenario:sethttpmeta-useragentvariant_not_exists_1

  • 🟥 max_rss_usage [+2.509MB; +2.665MB] or [+8.725%; +9.267%]

scenario:sethttpmeta-useragentvariant_not_exists_2

  • 🟥 max_rss_usage [+2.558MB; +2.723MB] or [+8.908%; +9.484%]

scenario:span-add-metrics

  • 🟥 max_rss_usage [+4.618MB; +4.801MB] or [+7.879%; +8.192%]

scenario:span-add-tags

  • 🟥 max_rss_usage [+2.401MB; +2.539MB] or [+5.863%; +6.198%]

scenario:span-start

  • 🟥 max_rss_usage [+1.705MB; +1.856MB] or [+3.558%; +3.873%]

scenario:span-start-finish

  • 🟥 max_rss_usage [+2.581MB; +2.719MB] or [+9.290%; +9.786%]

scenario:span-start-finish-telemetry

  • 🟥 max_rss_usage [+2.576MB; +2.716MB] or [+8.855%; +9.336%]

scenario:span-start-finish-traceid128

  • 🟥 max_rss_usage [+2.572MB; +2.737MB] or [+9.008%; +9.585%]

scenario:span-start-traceid128

  • 🟥 max_rss_usage [+1.939MB; +2.099MB] or [+4.051%; +4.386%]

scenario:tracer-large

  • 🟥 max_rss_usage [+2.618MB; +2.792MB] or [+8.999%; +9.594%]

scenario:tracer-medium

  • 🟥 max_rss_usage [+2.554MB; +2.701MB] or [+9.044%; +9.567%]

scenario:tracer-small

  • 🟥 max_rss_usage [+2.556MB; +2.739MB] or [+9.047%; +9.694%]

pr-commenter[bot] avatar Jul 27 '23 22:07 pr-commenter[bot]