dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(debugging): evaluate probe condition on exit

Open P403n1x87 opened this issue 3 years ago • 2 comments

Description

To align with other runtimes, this change ensures that the condition on a function probe is evaluated on function exit.

Checklist

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] Description motivates each change.
  • [ ] No unnecessary changes were introduced in this PR.
  • [ ] PR cannot be broken up into smaller PRs.
  • [ ] Avoid breaking API changes unless absolutely necessary.
  • [ ] Tests provided or description of manual testing performed is included in the code or PR.
  • [x] Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • [ ] All relevant GitHub issues are correctly linked.
  • [ ] Backports are identified and tagged with Mergifyio.
  • [ ] Add to milestone.

P403n1x87 avatar Sep 30 '22 10:09 P403n1x87

@P403n1x87 this pull request is now in conflict 😩

mergify[bot] avatar Oct 10 '22 13:10 mergify[bot]

Codecov Report

Merging #4247 (91d3459) into 1.x (dd1b0cf) will decrease coverage by 0.06%. The diff coverage is 18.57%.

@@            Coverage Diff             @@
##              1.x    #4247      +/-   ##
==========================================
- Coverage   78.24%   78.17%   -0.07%     
==========================================
  Files         745      747       +2     
  Lines       59359    59417      +58     
==========================================
+ Hits        46446    46452       +6     
- Misses      12913    12965      +52     
Impacted Files Coverage Δ
ddtrace/profiling/profiler.py 0.00% <0.00%> (ø)
tests/profiling/gunicorn-app.py 0.00% <0.00%> (ø)
tests/profiling/test_gunicorn.py 0.00% <0.00%> (ø)
ddtrace/debugging/_snapshot/collector.py 88.60% <44.44%> (-3.80%) :arrow_down:
tests/debugging/test_debugger.py 96.47% <100.00%> (+0.07%) :arrow_up:
tests/submod/stuff.py 73.49% <100.00%> (+0.65%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 14 '22 14:10 codecov-commenter