dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat(asm): fix segmentation fault parsing JSON in Python2

Open avara1986 opened this issue 3 years ago • 1 comments

Description

Fix Python 2 error reading WAF rules

Checklist

  • [x] Title must conform to conventional commit.
  • [x] Add additional sections for feat and fix pull requests.
  • [x] Ensure tests are passing for affected code.

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] Description motivates each change.
  • [ ] No unnecessary changes were introduced in this PR.
  • [ ] PR cannot be broken up into smaller PRs.
  • [ ] Avoid breaking API changes unless absolutely necessary.
  • [ ] Tests provided or description of manual testing performed is included in the code or PR.
  • [ ] Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • [ ] All relevant GitHub issues are correctly linked.
  • [ ] Backports are identified and tagged with Mergifyio.
  • [ ] Add to milestone.

avara1986 avatar Aug 12 '22 15:08 avara1986

Codecov Report

Merging #4082 (9ddcb9d) into 1.x (055110a) will increase coverage by 0.02%. The diff coverage is 80.86%.

@@            Coverage Diff             @@
##              1.x    #4082      +/-   ##
==========================================
+ Coverage   78.90%   78.93%   +0.02%     
==========================================
  Files         720      720              
  Lines       57046    57239     +193     
==========================================
+ Hits        45013    45181     +168     
- Misses      12033    12058      +25     
Impacted Files Coverage Δ
ddtrace/contrib/flask/patch.py 0.00% <0.00%> (ø)
tests/contrib/flask/test_flask_appsec.py 0.00% <0.00%> (ø)
tests/contrib/flask/test_flask_snapshot.py 0.00% <0.00%> (ø)
tests/integration/test_integration_snapshots.py 0.00% <0.00%> (ø)
tests/telemetry/test_telemetry.py 0.00% <0.00%> (ø)
tests/telemetry/test_writer.py 0.00% <ø> (ø)
ddtrace/internal/module.py 78.87% <66.66%> (-0.06%) :arrow_down:
ddtrace/contrib/django/utils.py 90.52% <88.23%> (+0.25%) :arrow_up:
ddtrace/internal/sampling.py 92.81% <88.67%> (+1.26%) :arrow_up:
ddtrace/constants.py 100.00% <100.00%> (ø)
... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 15 '22 16:08 codecov-commenter

@Mergifyio backport 0.x 0.61 1.3 1.4

avara1986 avatar Aug 16 '22 12:08 avara1986