dd-trace-py
dd-trace-py copied to clipboard
feat(rediscluster): rediscluster adding service name config option
Description
This will allow the configuration of the service name for the rediscluster integration
Checklist
- [x] Title must conform to conventional commit.
- [x] Add additional sections for
feat
andfix
pull requests. - [x] Ensure tests are passing for affected code.
- [x] Library documentation and/or Datadog's documentation site is updated. Link to doc PR in description.
Reviewer Checklist
- [ ] Title is accurate.
- [ ] Description motivates each change.
- [ ] No unnecessary changes were introduced in this PR.
- [ ] PR cannot be broken up into smaller PRs.
- [ ] Avoid breaking API changes unless absolutely necessary.
- [ ] Tests provided or description of manual testing performed is included in the code or PR.
- [ ] Release note has been added for fixes and features, or else
changelog/no-changelog
label added. - [ ] All relevant GitHub issues are correctly linked.
- [ ] Backports are identified and tagged with Mergifyio.
- [ ] Add to milestone.
For the tests, should they be similar to situations in which overrides don't occur as like the redis example here: https://github.com/DataDog/dd-trace-py/blob/1.x/tests/contrib/redis/test_redis.py#L225-L262
Might need more clarification on test use cases
Likewise, would we also include snapshots as tests for rediscluster?
Codecov Report
Merging #4059 (44756ab) into 1.x (04077e1) will decrease coverage by
0.01%
. The diff coverage is35.00%
.
@@ Coverage Diff @@
## 1.x #4059 +/- ##
==========================================
- Coverage 78.98% 78.96% -0.02%
==========================================
Files 720 720
Lines 56962 56981 +19
==========================================
+ Hits 44989 44997 +8
- Misses 11973 11984 +11
Impacted Files | Coverage Δ | |
---|---|---|
ddtrace/contrib/rediscluster/__init__.py | 100.00% <ø> (ø) |
|
tests/contrib/rediscluster/test.py | 82.11% <23.52%> (-9.40%) |
:arrow_down: |
ddtrace/contrib/rediscluster/patch.py | 98.07% <100.00%> (+0.07%) |
:arrow_up: |
ddtrace/contrib/cassandra/session.py | 87.84% <0.00%> (+1.10%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more