dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat: Support w3 traceparent headers

Open goodspark opened this issue 2 years ago • 6 comments

Fixes #3872

Description

Supports distributed tracing for services that want to use the W3 trace propagation headers. https://www.w3.org/TR/trace-context

Checklist

Motivation

Design

Testing strategy

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] Description motivates each change.
  • [ ] No unnecessary changes were introduced in this PR.
  • [ ] PR cannot be broken up into smaller PRs.
  • [ ] Avoid breaking API changes unless absolutely necessary.
  • [ ] Tests provided or description of manual testing performed is included in the code or PR.
  • [ ] Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • [ ] All relevant GitHub issues are correctly linked.
  • [ ] Backports are identified and tagged with Mergifyio.
  • [ ] Add to milestone.

goodspark avatar Jun 28 '22 06:06 goodspark

Hey @goodspark thanks for opening this PR!

We have been discussing lately about adding support for w3c context propagation headers. We are going to be discussing this internally over the next 1-2 weeks to solidify some of the details on how we want to support it (how to enable, what are the settings called, etc).

This is an awesome start to that work, but I want to wait until we have a more clearly defined specification for how we want this implemented across all languages so we don't have to come back to it later.

brettlangdon avatar Jun 28 '22 17:06 brettlangdon

Thanks for the update, Brett. Should we just close this for now then?

goodspark avatar Jul 06 '22 18:07 goodspark

Thanks for the update, Brett. Should we just close this for now then?

We can keep it open! I think the changes here are a great start so even if we take over the PR a good place to get started.

brettlangdon avatar Jul 06 '22 18:07 brettlangdon

This is perfect, @brettlangdon any news ?

felipeagger avatar Jul 12 '22 18:07 felipeagger

I'm waiting for this

leandrorebelo avatar Jul 12 '22 18:07 leandrorebelo

I'm looking forward to this feature

OrlandoBitencourt avatar Jul 12 '22 18:07 OrlandoBitencourt

@goodspark this pull request is now in conflict 😩

mergify[bot] avatar Sep 20 '22 17:09 mergify[bot]

This work was added in #4170, thanks @goodspark for kicking this off!

Kyle-Verhoog avatar Sep 20 '22 21:09 Kyle-Verhoog