dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat(django): Include django streaming took time

Open hugobranquinho opened this issue 3 years ago • 2 comments

Watch django streaming took time and add it to trace.django.request details

Checklist

  • [x] Library documentation is updated.
  • [x] Corp site documentation is updated (link to the PR).

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] Description motivates each change.
  • [ ] No unnecessary changes were introduced in this PR.
  • [ ] PR cannot be broken up into smaller PRs.
  • [ ] Avoid breaking API changes unless absolutely necessary.
  • [ ] Tests provided or description of manual testing performed is included in the code or PR.
  • [ ] Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • [ ] All relevant GitHub issues are correctly linked.
  • [ ] Backports are identified and tagged with Mergifyio.
  • [ ] Add to milestone.

hugobranquinho avatar Jun 14 '22 16:06 hugobranquinho

@hugobranquinho this pull request is now in conflict 😩

mergify[bot] avatar Jul 29 '22 12:07 mergify[bot]

@hugobranquinho this pull request is now in conflict 😩

mergify[bot] avatar Sep 26 '22 07:09 mergify[bot]

Thanks for the contribution @hugobranquinho, and apologies that it has sat for so long without a review. The basic idea and approach of this change makes sense to me. A lot has changed on the base branch since this was opened, so I'd recommend starting from scratch if you want to update this as opposed to trying to resolve the conflicts.

emmettbutler avatar Mar 21 '23 17:03 emmettbutler

@hugobranquinho thanks again for the contribution. Since this has not had any activity for awhile I am going to close the PR, but please feel free to resolve the merge conflicts and reopen whenever you are ready!

brettlangdon avatar May 03 '23 13:05 brettlangdon