dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

accept DD_APP_KEY and log warnings for DD_APPLICATION_KEY

Open gary-huang opened this issue 5 months ago • 2 comments

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

gary-huang avatar Jun 26 '25 15:06 gary-huang

CODEOWNERS have been resolved as:

ddtrace/llmobs/experimentation/_config.py                               @DataDog/ml-observability
tests/llmobs/test_experimentation_config.py                             @DataDog/ml-observability

github-actions[bot] avatar Jun 26 '25 15:06 github-actions[bot]

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 2 ms.

The average import time from base is: 234 ± 2 ms.

The import time difference between this PR and base is: -1.97 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.970 ms (0.85%)
ddtrace.bootstrap.sitecustomize 1.302 ms (0.56%)
ddtrace.bootstrap.preload 1.302 ms (0.56%)
ddtrace.internal.products 1.302 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.639 ms (0.28%)
ddtrace 0.667 ms (0.29%)
ddtrace.internal._unpatched 0.025 ms (0.01%)
json 0.025 ms (0.01%)
json.decoder 0.025 ms (0.01%)
re 0.025 ms (0.01%)
enum 0.025 ms (0.01%)
types 0.025 ms (0.01%)

github-actions[bot] avatar Jun 26 '25 15:06 github-actions[bot]