dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

ci: move DI exploration tests to GitLab

Open P403n1x87 opened this issue 5 months ago • 3 comments

We extract the exploration tests from the rest of the framework tests and move them to GitLab.

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

P403n1x87 avatar Jun 26 '25 10:06 P403n1x87

CODEOWNERS have been resolved as:

.gitlab/templates/debugging/exploration.yml                             @DataDog/python-guild @DataDog/apm-core-python
tests/debugging/exploration/pytest/exploration.py                       @DataDog/debugger-python
.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/debugging/exploration/_config.py                                  @DataDog/debugger-python
tests/debugging/exploration/_coverage.py                                @DataDog/debugger-python
tests/debugging/exploration/_profiler.py                                @DataDog/debugger-python
tests/debugging/exploration/debugger.py                                 @DataDog/debugger-python
tests/debugging/exploration/test_bootstrap.py                           @DataDog/debugger-python
tests/debugging/exploration/utils.py                                    @DataDog/debugger-python

github-actions[bot] avatar Jun 26 '25 10:06 github-actions[bot]

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 282 ± 3 ms.

The average import time from base is: 283 ± 4 ms.

The import time difference between this PR and base is: -0.1 ± 0.1 ms.

The difference is not statistically significant (z = -0.73).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.805 ms (0.64%)
ddtrace.bootstrap.sitecustomize 1.133 ms (0.40%)
ddtrace.bootstrap.preload 1.133 ms (0.40%)
ddtrace.internal.remoteconfig.client 0.613 ms (0.22%)
ddtrace 0.672 ms (0.24%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

github-actions[bot] avatar Jun 26 '25 10:06 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-07-01 19:07:59

Comparing candidate commit df75e457649456ff6666a3482354bf660cf7e7f3 in PR branch ci/extract-di-exploration-tests with baseline commit 329258474e6989e1299edfdb9ba13ff26b248fc5 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 545 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+339.788ns; +417.710ns] or [+9.645%; +11.857%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+463.628ns; +519.132ns] or [+12.581%; +14.087%]

pr-commenter[bot] avatar Jun 26 '25 11:06 pr-commenter[bot]