dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

ci(gitlab): disable sccache

Open P403n1x87 opened this issue 5 months ago • 3 comments

We disable sccache in GitLab base venv building to save some extra time. Because we now use cached artifacts and incremental builds, the use of sccache in those jobs has become redundant. By not installing sccache we now save some extra bit of time.

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

P403n1x87 avatar Jun 19 '25 10:06 P403n1x87

CODEOWNERS have been resolved as:

scripts/gen_ext_cache_scripts.py                                        @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python

github-actions[bot] avatar Jun 19 '25 10:06 github-actions[bot]

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 3 ms.

The average import time from base is: 281 ± 3 ms.

The import time difference between this PR and base is: -1.9 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.991 ms (0.71%)
ddtrace.bootstrap.sitecustomize 1.316 ms (0.47%)
ddtrace.bootstrap.preload 1.316 ms (0.47%)
ddtrace.internal.remoteconfig.client 0.634 ms (0.23%)
ddtrace 0.675 ms (0.24%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

github-actions[bot] avatar Jun 19 '25 10:06 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-06-20 20:47:34

Comparing candidate commit 0fe9f6292dd212722cea297ba8ae7c3891547f9b in PR branch ci/gitlab-remove-sccache with baseline commit 693194395f65e8731ef828d2c865a8c62e298d35 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 558 metrics, 3 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+183.247ns; +218.783ns] or [+8.161%; +9.743%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+822.921ns; +904.895ns] or [+19.450%; +21.387%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+386.013ns; +437.188ns] or [+11.150%; +12.628%]

pr-commenter[bot] avatar Jun 19 '25 11:06 pr-commenter[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jul 23 '25 00:07 github-actions[bot]