dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix: potential refence to undefined var in algoliasearch [backport 2.21]

Open github-actions[bot] opened this issue 5 months ago • 2 comments

Backport a653199978126e86d089f41cc4f682643e6843ac from #13692 to 2.21.

Checklist

  • [X] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [x] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions[bot] avatar Jun 18 '25 12:06 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-06-18 13:30:24

Comparing candidate commit 09f358cd5c948ae838f622d47c2fa8840fff3299 in PR branch backport-13692-to-2.21 with baseline commit 89e8597a02cb00bb1b11e0036817dd5a1fdc4662 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 344 metrics, 2 unstable metrics.

pr-commenter[bot] avatar Jun 18 '25 13:06 pr-commenter[bot]

CODEOWNERS have been resolved as:

releasenotes/notes/algoliasearch-dangling-ref-e7a5086104d1761b.yaml     @DataDog/apm-python
ddtrace/contrib/internal/algoliasearch/patch.py                         @DataDog/apm-core-python @DataDog/apm-idm-python

github-actions[bot] avatar Jun 18 '25 14:06 github-actions[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jul 20 '25 00:07 github-actions[bot]