dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

test(hackathon): Add Darwin build to OCI

Open BaptisteFoy opened this issue 5 months ago • 3 comments

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

BaptisteFoy avatar Jun 17 '25 12:06 BaptisteFoy

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python
.gitlab/download-dependency-wheels.sh                                   @DataDog/python-guild @DataDog/apm-core-python
.gitlab/prepare-oci-package.sh                                          @DataDog/python-guild @DataDog/apm-core-python
lib-injection/dl_wheels.py                                              @DataDog/apm-core-python
lib-injection/sources/sitecustomize.py                                  @DataDog/apm-core-python

github-actions[bot] avatar Jun 17 '25 12:06 github-actions[bot]

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 281 ± 4 ms.

The average import time from base is: 283 ± 4 ms.

The import time difference between this PR and base is: -2.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.031 ms (0.72%)
ddtrace.bootstrap.sitecustomize 1.350 ms (0.48%)
ddtrace.bootstrap.preload 1.350 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.641 ms (0.23%)
ddtrace 0.680 ms (0.24%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

github-actions[bot] avatar Jun 17 '25 12:06 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-06-18 13:23:04

Comparing candidate commit 8bd823e8f58e0300c49f043579de1c4fd8a7ea84 in PR branch baptiste.foy/FA/hackathon-macos-build with baseline commit b9d71bf1bb7ba8ce4767d304f5c767a028de90d4 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 560 metrics, 3 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+188.590ns; +228.819ns] or [+8.384%; +10.173%]

pr-commenter[bot] avatar Jun 17 '25 13:06 pr-commenter[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jul 20 '25 00:07 github-actions[bot]