dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix(di): prevent exception when removing unresolved probe [backport 2.21]

Open github-actions[bot] opened this issue 6 months ago • 3 comments

Backport ebc7e4db93f57b2db27c3688871ffcf310b413f6 from #13357 to 2.21.

We prevent an exception from occurring when trying to remove a probe that did not resolve to a valid source code location.

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [x] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions[bot] avatar May 12 '25 13:05 github-actions[bot]

CODEOWNERS have been resolved as:

releasenotes/notes/fix-unresolved-pending-probe-removal-80fbf85a9c068122.yaml  @DataDog/apm-python
ddtrace/debugging/_probe/registry.py                                    @DataDog/debugger-python
tests/debugging/probe/test_registry.py                                  @DataDog/debugger-python

github-actions[bot] avatar May 12 '25 14:05 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-06-23 19:54:14

Comparing candidate commit 44c77e3e425399289b5803ba4e6b252c8402d5d7 in PR branch backport-13357-to-2.21 with baseline commit 89e8597a02cb00bb1b11e0036817dd5a1fdc4662 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 344 metrics, 2 unstable metrics.

pr-commenter[bot] avatar May 12 '25 14:05 pr-commenter[bot]

No data reported at this time.
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 82fffbb | Was this helpful? Give us feedback!