dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(profiling): endpoint call counter returns empty when disabled

Open taegyunkim opened this issue 1 year ago • 1 comments

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

taegyunkim avatar Oct 23 '24 23:10 taegyunkim

CODEOWNERS have been resolved as:

ddtrace/internal/processor/endpoint_call_counter.py                     @DataDog/apm-core-python
tests/profiling/exporter/test_http.py                                   @DataDog/profiling-python

github-actions[bot] avatar Oct 23 '24 23:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-10-24 00:26:52

Comparing candidate commit e27b7f113f9b295847f8ee600a5ceb495fba575a in PR branch taegyunkim/prof-10736-refactor-span-counter with baseline commit 2b410f95802b75528b3fb25023a942a5495b7f4a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 365 metrics, 53 unstable metrics.

pr-commenter[bot] avatar Oct 24 '24 00:10 pr-commenter[bot]