dd-trace-py
dd-trace-py copied to clipboard
perf(di): no path resolution in code origin for spans
We avoid resolving paths in code origin for spans as this is an expensive operation. Because there is path resolution logic in the backend, this step is not strictly required. Should this change in the future we can look into adding a cache instead.
Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the library release note guidelines
- The change includes or references documentation updates if necessary
- Backport labels are set (if applicable)
Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking API changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the release branch maintenance policy
CODEOWNERS have been resolved as:
ddtrace/debugging/_origin/span.py @DataDog/debugger-python
Benchmarks
Benchmark execution time: 2024-10-24 09:31:28
Comparing candidate commit 08443482edce2d56e11921cf01f2caa2e103fa8c in PR branch gab/test-delme with baseline commit 0b87e352035376364dc7f48dbf046013417ac4f9 in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 365 metrics, 53 unstable metrics.