dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(telemetry): poc add library memfd to discover injected processes

Open raphaelgavache opened this issue 1 year ago • 2 comments
trafficstars

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

raphaelgavache avatar Oct 16 '24 18:10 raphaelgavache

CODEOWNERS have been resolved as:

ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python

github-actions[bot] avatar Oct 16 '24 18:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-10-16 22:24:24

Comparing candidate commit 6699444d9a6b95afbe857bc2747ee456dc46295f in PR branch raphael/memfd_telem with baseline commit 4cbc4edc1df0691784c6c19228cf45cf8639862a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

pr-commenter[bot] avatar Oct 16 '24 22:10 pr-commenter[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jan 16 '25 00:01 github-actions[bot]