dd-trace-py
dd-trace-py copied to clipboard
WIP: remove DD_IAST_ENABLED env var usage
Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the library release note guidelines
- The change includes or references documentation updates if necessary
- Backport labels are set (if applicable)
Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking API changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the release branch maintenance policy
CODEOWNERS have been resolved as:
ddtrace/_monkey.py @DataDog/apm-core-python
ddtrace/_trace/tracer.py @DataDog/apm-sdk-api-python
ddtrace/appsec/_asm_request_context.py @DataDog/asm-python
ddtrace/appsec/_common_module_patches.py @DataDog/asm-python
ddtrace/appsec/_handlers.py @DataDog/asm-python
ddtrace/appsec/_iast/__init__.py @DataDog/asm-python
ddtrace/appsec/_iast/_loader.py @DataDog/asm-python
ddtrace/appsec/_iast/_patch.py @DataDog/asm-python
ddtrace/appsec/_iast/_patches/json_tainting.py @DataDog/asm-python
ddtrace/appsec/_iast/_utils.py @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/command_injection.py @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/header_injection.py @DataDog/asm-python
ddtrace/bootstrap/preload.py @DataDog/apm-core-python
ddtrace/contrib/dbapi/__init__.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/dbapi_async/__init__.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/fastapi/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/httplib/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/langchain/patch.py @DataDog/ml-observability
ddtrace/contrib/internal/mysql/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/mysqldb/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/requests/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/sqlalchemy/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/sqlite3/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/starlette/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/urllib/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/urllib3/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/webbrowser/patch.py @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/debug.py @DataDog/apm-core-python
ddtrace/settings/asm.py @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py @DataDog/asm-python
tests/appsec/iast/fixtures/integration/main_configure.py @DataDog/asm-python
tests/appsec/iast/test_loader.py @DataDog/asm-python
tests/contrib/dbapi/test_dbapi_appsec.py @DataDog/asm-python
tests/contrib/django/test_django_appsec.py @DataDog/asm-python
tests/contrib/django/test_django_appsec_iast.py @DataDog/asm-python
Benchmarks
Benchmark execution time: 2024-10-16 15:27:41
Comparing candidate commit cd8f676de5ebebe921f2c5c5427a70e599f294b6 in PR branch gnufede/iast-remove-env-var-usage-2 with baseline commit 4cbc4edc1df0691784c6c19228cf45cf8639862a in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.
Datadog Report
Branch report: gnufede/iast-remove-env-var-usage-2
Commit report: cd8f676
Test service: dd-trace-py
:white_check_mark: 0 Failed, 592 Passed, 694 Skipped, 19m 0.6s Total duration (17m 50.74s time saved)