dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix(profiling): make endpoint as dynamic as the tracer does

Open sanchda opened this issue 1 year ago • 2 comments

Customers report that some ways of using a non-default tracer configuration can result in the profiler failing to acquire the correct configuration.

This patch makes the profiler fully dynamic, like the tracer.

(if this is an unintentional feature of the tracer, we should probably still merge this patch and address the defect in the tracer in a later patch)

Checklist

  • [X] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

PROF-10698

sanchda avatar Oct 10 '24 16:10 sanchda

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/ddup/_ddup.pyi                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyx                       @DataDog/profiling-python
ddtrace/profiling/exporter/http.py                                      @DataDog/profiling-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python
ddtrace/profiling/scheduler.py                                          @DataDog/profiling-python

github-actions[bot] avatar Oct 10 '24 16:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-10-11 11:27:06

Comparing candidate commit 3d6f98122d9bf2d88597420166bdc104925b99a8 in PR branch profiling_cool_kids_club/dynamic_endpoint with baseline commit 79cd78dbc4aa5b0c512402c07a1d9d8e2d0c23bc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

pr-commenter[bot] avatar Oct 11 '24 11:10 pr-commenter[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jan 11 '25 00:01 github-actions[bot]