dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

Aiopg patch doesn't work with aiopg 1.0.0

Open kestein opened this issue 6 years ago • 3 comments

As of aiopg 1.0.0 there is no longer an aiopg.connection._connect function. The current release of ddtrace patches this function and will no longer work.

kestein avatar Sep 27 '19 22:09 kestein

I've tried to make fix, but I think that the tests will have to be rewritten as well. Aiopg 1.0 is only compatible with the async/await syntax, which is not used everywhere in ddtrace.

k4nar avatar Apr 03 '20 12:04 k4nar

I think we avoided the async/await syntax because we used to support Python 3.4. That's not the case anymore, so we should be fine using it now.

jd avatar Apr 03 '20 15:04 jd

I'll work on this here https://github.com/DataDog/dd-trace-py/pull/973

thehesiod avatar Apr 17 '20 16:04 thehesiod

@DataDog/apm-framework-integrations-reviewers-py

emmettbutler avatar Aug 28 '23 17:08 emmettbutler

The request for an aiopg>=1.0.0 integration is in our team's feature backlog and is not planned for the short term. As part of the backlog it will be considered during feature prioritization.

If anyone reading this is motivated to contribute the integration, please do so.

emmettbutler avatar Nov 03 '23 14:11 emmettbutler

As of now not only does the patching fail but the exception seems to be unhandled causing the application to fail. Does this hold true? If so it's quite an issue for us and I'd like ddtrace to handle its internal exception not leaking them them to the application us it.

gs11 avatar Jan 16 '24 12:01 gs11