dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(ci): build linux wheels in GitLab

Open brettlangdon opened this issue 1 year ago • 3 comments

Depends on #10259

Checklist

  • [ ] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

brettlangdon avatar Aug 17 '24 18:08 brettlangdon

CODEOWNERS have been resolved as:

.gitlab/repair_wheel_linux.sh                                           @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
.gitlab/download-dependency-wheels.sh                                   @DataDog/python-guild @DataDog/apm-core-python
.gitlab/download-wheels-from-gh-actions.sh                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.gitlab/prepare-oci-package.sh                                          @DataDog/python-guild @DataDog/apm-core-python
lib-injection/dl_wheels.py                                              @DataDog/apm-core-python

github-actions[bot] avatar Aug 17 '24 18:08 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-08-19 18:38:19

Comparing candidate commit ebfde9f9b9c6facb986d8469a19efd0b12a123a6 in PR branch brettlangdon/gitlab-build with baseline commit cea70f54b31749cb0cd035e2da28e0512c12b4e2 in branch brettlangdon/build.base.venvs.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

pr-commenter[bot] avatar Aug 17 '24 19:08 pr-commenter[bot]

This PR moves only the linux builds over, and then we'll download the windows and macos builds from GitHub actions... however... setuptools_scm is giving us different versions when building in GitHub Actions vs GitLab.

brettlangdon avatar Aug 18 '24 12:08 brettlangdon

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Nov 18 '24 00:11 github-actions[bot]