dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(ci): add logging when pytest raised OSError on shutdown

Open sanchda opened this issue 1 year ago • 4 comments

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [x] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

sanchda avatar Aug 15 '24 03:08 sanchda

CODEOWNERS have been resolved as:

tests/conftest.py                                                       @DataDog/apm-core-python

github-actions[bot] avatar Aug 15 '24 03:08 github-actions[bot]

Datadog Report

Branch report: sanchda/force_ci_001 Commit report: ebea86d Test service: dd-trace-py

:white_check_mark: 0 Failed, 122092 Passed, 56396 Skipped, 4h 1m 22.48s Total duration (5h 6m 42.9s time saved)

Codecov Report

Attention: Patch coverage is 19.51220% with 33 lines in your changes missing coverage. Please review.

Project coverage is 9.62%. Comparing base (1f640b9) to head (ebea86d). Report is 2 commits behind head on main.

Files Patch % Lines
tests/conftest.py 19.51% 33 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10239       +/-   ##
===========================================
- Coverage   71.95%    9.62%   -62.34%     
===========================================
  Files        1490     1400       -90     
  Lines      132342   124822     -7520     
===========================================
- Hits        95225    12010    -83215     
- Misses      37117   112812    +75695     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 15 '24 04:08 codecov-commenter

Benchmarks

Benchmark execution time: 2024-08-15 05:43:45

Comparing candidate commit ebea86d1bfc92211b90bc3f1519e330f2bb01411 in PR branch sanchda/force_ci_001 with baseline commit a657198d3340f15faaf014892522a4e6d57a9e35 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

pr-commenter[bot] avatar Aug 15 '24 05:08 pr-commenter[bot]

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Nov 15 '24 00:11 github-actions[bot]