dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(ci): add CI image for running native profiling checks

Open sanchda opened this issue 1 year ago • 4 comments

Since profiling contains quite a bit of native code, it has a number of native checks (running with sanitizers, static analysis, etc) that's done outside of our normal build operation. This PR adds an image which can be used to perform those tests in CI

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

sanchda avatar Aug 06 '24 01:08 sanchda

  • #10097 Graphite
  • #10096 Graphite
  • #10095 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanchda and the rest of your teammates on Graphite Graphite

sanchda avatar Aug 06 '24 01:08 sanchda

CODEOWNERS have been resolved as:

.github/workflows/build_profiling_native_checks_image.yml               @DataDog/python-guild @DataDog/apm-core-python
docker/Dockerfile.profiling_native_checks                               @DataDog/apm-core-python

github-actions[bot] avatar Aug 06 '24 01:08 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-08-14 21:38:19

Comparing candidate commit 2243ea0987f5872336bb6d0c502b56c176568ef8 in PR branch 08-06-chore_ci_add_system_for_packaging_cppcheck_in_gpr with baseline commit a657198d3340f15faaf014892522a4e6d57a9e35 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 354 metrics, 46 unstable metrics.

pr-commenter[bot] avatar Aug 06 '24 02:08 pr-commenter[bot]

Datadog Report

Branch report: 08-06-chore_ci_add_system_for_packaging_cppcheck_in_gpr Commit report: 859f92a Test service: dd-trace-py

:white_check_mark: 0 Failed, 150312 Passed, 27109 Skipped, 8h 18m 57.06s Total duration (1h 12m 33.36s time saved) :hourglass: 2 Performance Regressions

:hourglass: Performance Regressions vs Default Branch (2)

  • test_and_emit_get_version - test_pylibmc_patch.py 5.92s (+5.39s, +1025%) - Details
  • test_tracing_context_is_not_propagated_by_default - test_kafka.py 1m 30.01s (+1m 25.99s, +2139%) - Details

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Nov 14 '24 00:11 github-actions[bot]