dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

feat(Symfony): Check cache.app is reachable before use

Open Leiyks opened this issue 3 weeks ago • 2 comments

Description

This PR add a readyness check on the Symfony cache app in case the service is unavailable. The absence of this check can be the cause for significant latency increase when the cache app is not available as we are fetching all the routes in that case.

Leiyks avatar Dec 02 '25 14:12 Leiyks

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-03 16:02:16

Comparing candidate commit ea33259f098ecb2268bb2c01f0797afd10d17120 in PR branch leiyks/APMS-17485 with baseline commit 2790073f21c7ada33197d1ced184f02d81ee9aa0 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-6.540µs; -5.580µs] or [-5.984%; -5.106%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-3.638µs; -2.342µs] or [-3.259%; -2.098%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-51.710µs; -42.990µs] or [-11.200%; -9.311%]

pr-commenter[bot] avatar Dec 02 '25 15:12 pr-commenter[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.69%. Comparing base (2790073) to head (ea33259).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
- Coverage   61.81%   61.69%   -0.12%     
==========================================
  Files         142      142              
  Lines       12923    12923              
  Branches     1695     1695              
==========================================
- Hits         7988     7973      -15     
- Misses       4183     4196      +13     
- Partials      752      754       +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2790073...ea33259. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 02 '25 16:12 codecov-commenter