dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

feat(prof): use reqwest to send profiles to agent

Open morrisonlevi opened this issue 6 months ago • 2 comments

Description

Evaluate using reqwest directly instead of using libdatadog's profiling exporter. Specifically, look at the Unix Domain Sockets (UDS) support.

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [ ] Appropriate labels assigned.

morrisonlevi avatar Jul 11 '25 14:07 morrisonlevi

Benchmarks [ profiler ]

Benchmark execution time: 2025-07-15 22:09:05

Comparing candidate commit ba8f818cb1c79d11247c4e90ef93ca7dbc96e0c8 in PR branch levi/reqwest with baseline commit 60f33e99030533b7e6b9c138770e4364c1298b9b in branch levi/cargo-deps.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟩 max_rss_usage [-1.444MB; -0.706MB] or [-4.530%; -2.217%]

pr-commenter[bot] avatar Jul 11 '25 14:07 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.72%. Comparing base (60f33e9) to head (25d0c84).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           levi/cargo-deps    #3340      +/-   ##
===================================================
- Coverage            61.83%   61.72%   -0.12%     
===================================================
  Files                  140      140              
  Lines                12318    12318              
  Branches              1617     1617              
===================================================
- Hits                  7617     7603      -14     
- Misses                3989     4002      +13     
- Partials               712      713       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60f33e9...25d0c84. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 11 '25 15:07 codecov-commenter