dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Add http.route tag to SymfonyIntegration.php

Open cataphract opened this issue 11 months ago • 4 comments

Description

Adds http.route to symfony. Supersedes https://github.com/DataDog/dd-trace-php/pull/2710 and https://github.com/DataDog/dd-trace-php/pull/2477

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [ ] Appropriate labels assigned.

cataphract avatar Dec 12 '24 02:12 cataphract

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.93%. Comparing base (38ce35a) to head (6df661a). :warning: Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
- Coverage   61.96%   61.93%   -0.03%     
==========================================
  Files         140      140              
  Lines       12388    12388              
  Branches     1622     1622              
==========================================
- Hits         7676     7673       -3     
- Misses       3999     4002       +3     
  Partials      713      713              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38ce35a...6df661a. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 12 '24 02:12 codecov-commenter

Benchmarks [ tracer ]

Benchmark execution time: 2025-08-05 16:10:46

Comparing candidate commit 6df661afe854376702aa5c7516b26eb86bc51363 in PR branch glopes/symfony-route with baseline commit 38ce35a8a2683e69c50d21450f8e4b72276862a4 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+4.595µs; +5.449µs] or [+7.355%; +8.723%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-4.522µs; -3.613µs] or [-6.729%; -5.376%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟥 execution_time [+162.887µs; +271.453µs] or [+2.059%; +3.431%]

pr-commenter[bot] avatar Dec 12 '24 03:12 pr-commenter[bot]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

github-actions[bot] avatar Dec 12 '24 14:12 github-actions[bot]

I am missing tests with optional parameters https://symfony.com/doc/current/routing.html#optional-parameters, more than one locale https://symfony.com/doc/current/routing.html#localized-routes-i18n

estringana avatar Dec 17 '24 14:12 estringana