[DRAFT] ASM Standalone

[estringana]

trafficstars

Description

Work in progress

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.72%. Comparing base (4cc2897) to head (13d4688).

Files with missing lines	Patch %	Lines
appsec/src/extension/ddtrace.c	60.00%	3 Missing and 3 partials :warning:
appsec/src/extension/tags.c	66.66%	0 Missing and 3 partials :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2903      +/-   ##
============================================
- Coverage     72.75%   72.72%   -0.03%     
  Complexity     2750     2750              
============================================
  Files           138      138              
  Lines         15038    15060      +22     
  Branches       1020     1026       +6     
============================================
+ Hits          10941    10953      +12     
- Misses         3543     3548       +5     
- Partials        554      559       +5     

Flag	Coverage Δ
appsec-extension	67.95% <64.00%> (-0.03%)	:arrow_down:
tracer-php	74.55% <ø> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
appsec/src/extension/commands_helpers.c	63.65% <100.00%> (+0.08%)	:arrow_up:
appsec/src/extension/configuration.h	100.00% <ø> (ø)
appsec/src/extension/tags.c	79.67% <66.66%> (-0.13%)	:arrow_down:
appsec/src/extension/ddtrace.c	57.41% <60.00%> (+0.15%)	:arrow_up:

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cc2897...13d4688. Read the comment docs.

[pr-commenter[bot]]

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-13 11:23:43

Comparing candidate commit 13d468824a6968caf36c960ea3eb746874d09cdf in PR branch estringana/asm-standalone-2 with baseline commit 4cc2897a27f6165ccaee32436216b27a9d2d4f75 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-15.083µs; -10.459µs] or [-7.756%; -5.378%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-13.408µs; -7.795µs] or [-6.879%; -3.999%]

[pr-commenter[bot]]

Benchmarks [ appsec ]

Benchmark execution time: 2024-12-13 11:30:10

Comparing candidate commit 13d468824a6968caf36c960ea3eb746874d09cdf in PR branch estringana/asm-standalone-2 with baseline commit 4cc2897a27f6165ccaee32436216b27a9d2d4f75 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

[estringana]

@iamluc I did fix the segmentation fault and also address your suggestion. Can you review again plz? 🙏