dd-trace-php
dd-trace-php copied to clipboard
[Feature] installers should detect embed SAPI as well
Describe the feature you'd like
Currently both .deb installer and datadog-setup.php do not detect the embed sapi, when installed from sury.org repository (libphp8.0-embed package).
The difference is that inis are in different folders:
# ls -al /etc/php/8.0/
cli/ embed/ mods-available/
Is your feature request related to a problem?
No response
Describe alternatives you've considered
Currently we do:
RUN curl -L -o datadog-setup.php https://github.com/DataDog/dd-trace-php/releases/latest/download/datadog-setup.php \
&& php datadog-setup.php --php-bin all \
&& cp /etc/php/8.0/cli/conf.d/98-ddtrace.ini /etc/php/8.0/embed/conf.d/
Additional context
output from php script installer:
#26 11.74 Installed required source files to '/opt/datadog/dd-library/1.2.0'
#26 11.75 Installing to binary: php (/usr/bin/php8.0)
#26 11.82 Installing extension to /usr/lib/php/20200930
#26 11.83 Copied '/tmp/dd-install/dd-library-php/trace/ext/20200930/ddtrace.so' to '/usr/lib/php/20200930/ddtrace.so'
#26 11.84 Copied '/tmp/dd-install/dd-library-php/profiling/ext/20200930/datadog-profiling.so' to '/usr/lib/php/20200930/datadog-profiling.so'
#26 11.84 Copied '/tmp/dd-install/dd-library-php/appsec/ext/20200930/ddappsec.so' to '/usr/lib/php/20200930/ddappsec.so'
#26 11.84 Created INI file '/etc/php/8.0/cli/conf.d/98-ddtrace.ini'
#26 11.84 Installation to 'php (/usr/bin/php8.0)' was successful
#26 11.84 Installing to binary: php8.0 (/usr/bin/php8.0)
#26 11.92 Installing extension to /usr/lib/php/20200930
#26 11.93 Copied '/tmp/dd-install/dd-library-php/trace/ext/20200930/ddtrace.so' to '/usr/lib/php/20200930/ddtrace.so'
#26 11.94 Copied '/tmp/dd-install/dd-library-php/profiling/ext/20200930/datadog-profiling.so' to '/usr/lib/php/20200930/datadog-profiling.so'
#26 11.94 Copied '/tmp/dd-install/dd-library-php/appsec/ext/20200930/ddappsec.so' to '/usr/lib/php/20200930/ddappsec.so'
#26 11.94 Updating existing INI file '/etc/php/8.0/cli/conf.d/98-ddtrace.ini'
#26 11.94 Installation to 'php8.0 (/usr/bin/php8.0)' was successful
#26 11.94 --------------------------------------------------
#26 11.94 SUCCESS
This also does not work:
RUN curl -L https://github.com/DataDog/dd-trace-php/releases/download/${DDTRACE_VERSION}/datadog-php-tracer_${DDTRACE_VERSION}_${TARGETARCH}.deb \
-o ddtrace.deb && dpkg -i ddtrace.deb && rm -rf ddtrace.deb
output from deb package installer:
#25 1.234 Unpacking datadog-php-tracer (0.89.0) ...
#25 2.871 Setting up datadog-php-tracer (0.89.0) ...
#25 2.887 ### PHP version
#25 2.910 PHP 8.0.30 (cli) (built: Aug 2 2024 16:05:50) ( NTS )
#25 2.910 Copyright (c) The PHP Group
#25 2.910 Zend Engine v4.0.30, Copyright (c) Zend Technologies
#25 2.910 with Zend OPcache v8.0.30, Copyright (c), by Zend Technologies
#25 2.915 ### Installing Datadog PHP tracing extension (ddtrace)
#25 2.915 ###
#25 2.916 ### Logging /usr/bin/php -i to a file
#25 2.916 ###
#25 3.102 Checking for extension: json
#25 3.132 Extension 'json' was found.
#25 3.132 ### Creating ddtrace.ini
#25 3.132 ###
#25 3.132
#25 3.133 ; ***** DO NOT EDIT THIS FILE *****
#25 3.133 ; To overwrite the INI settings for this extension, edit
#25 3.133 ; the INI file in this directory called "ddtrace-custom.ini"
#25 3.133
#25 3.133 [datadog]
#25 3.133 extension=/opt/datadog-php/extensions/ddtrace-20200930.so
#25 3.133 datadog.trace.request_init_hook=/opt/datadog-php/dd-trace-sources/bridge/dd_wrap_autoloader.php
#25 3.133 ### ddtrace.ini created
#25 3.133 ###
#25 3.134 ### Created empty /opt/datadog-php/etc/ddtrace-custom.ini
#25 3.134 ###
#25 3.134 ### Linking ddtrace.ini for supported SAPI's
#25 3.134 ###
#25 3.134
#25 3.134 ### Found SAPI config directory: /etc/php/8.0/cli/conf.d
#25 3.134 ### Linking ddtrace.ini to /etc/php/8.0/cli/conf.d/98-ddtrace.ini
#25 3.135 ### Linking ddtrace-custom.ini to /etc/php/8.0/cli/conf.d/99-ddtrace-custom.ini
#25 3.136 ###
#25 3.168 ddtrace
#25 3.168 ddtrace
#25 3.168 ### Extension enabled successfully
Thank you! R