WAF telemetry

[cataphract]

Description

See individual commits for descriptions of the changes.

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 34.83146% with 58 lines in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (196c7f2) to head (b30d87e).

Files with missing lines	Patch %	Lines
appsec/src/extension/commands_helpers.c	36.50%	39 Missing and 1 partial :warning:
appsec/src/extension/ddtrace.c	34.78%	11 Missing and 4 partials :warning:
appsec/src/extension/commands/client_init.c	0.00%	2 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2735      +/-   ##
============================================
- Coverage     74.82%   72.90%   -1.92%     
  Complexity     2741     2741              
============================================
  Files           110      137      +27     
  Lines         10863    14978    +4115     
  Branches          0     1016    +1016     
============================================
+ Hits           8128    10920    +2792     
- Misses         2735     3506     +771     
- Partials          0      552     +552     

Flag	Coverage Δ
appsec-extension	67.84% <34.83%> (?)
tracer-php	74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
appsec/src/extension/request_abort.c	72.28% <ø> (ø)
appsec/src/extension/commands/client_init.c	80.43% <0.00%> (ø)
appsec/src/extension/ddtrace.c	57.25% <34.78%> (ø)
appsec/src/extension/commands_helpers.c	63.56% <36.50%> (ø)

... and 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 196c7f2...b30d87e. Read the comment docs.

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-07-13 00:47:21

Comparing candidate commit a225a900b45f0b083ea8748dd2244bf5b7c20d89 in PR branch glopes/waf-telemetry with baseline commit 4c3832dd87909e43748538f72a40f0b4db690c1a in branch master.

Found 17 performance improvements and 0 performance regressions! Performance is the same for 161 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

• 🟩 execution_time [-398.670µs; -235.850µs] or [-14.264%; -8.439%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

• 🟩 execution_time [-430.977µs; -266.503µs] or [-14.768%; -9.132%]

scenario:EmptyFileBench/benchEmptyFileOverhead

• 🟩 execution_time [-500.727µs; -340.853µs] or [-15.926%; -10.841%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

• 🟩 execution_time [-541.737µs; -402.743µs] or [-16.620%; -12.356%]

scenario:LaravelBench/benchLaravelBaseline

• 🟩 execution_time [-419.144µs; -246.976µs] or [-14.387%; -8.478%]

scenario:LaravelBench/benchLaravelBaseline-opcache

• 🟩 execution_time [-407.735µs; -267.945µs] or [-13.502%; -8.873%]

scenario:LaravelBench/benchLaravelOverhead

• 🟩 execution_time [-606.339µs; -426.181µs] or [-18.143%; -12.753%]

scenario:LaravelBench/benchLaravelOverhead-opcache

• 🟩 execution_time [-565.431µs; -362.429µs] or [-16.594%; -10.636%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

• 🟩 execution_time [-7.998µs; -5.782µs] or [-3.347%; -2.419%]

scenario:SymfonyBench/benchSymfonyBaseline

• 🟩 execution_time [-300.154µs; -218.546µs] or [-5.000%; -3.641%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

• 🟩 execution_time [-314.024µs; -269.696µs] or [-5.139%; -4.413%]

scenario:SymfonyBench/benchSymfonyOverhead

• 🟩 execution_time [-734.478µs; -678.602µs] or [-10.406%; -9.615%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

• 🟩 execution_time [-720.026µs; -639.954µs] or [-10.068%; -8.948%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-8.473µs; -5.227µs] or [-4.195%; -2.588%]

scenario:TraceSerializationBench/benchSerializeTrace-opcache

• 🟩 mem_peak [-167.139KB; -62.645KB] or [-7.538%; -2.825%]

scenario:WordPressBench/benchWordPressOverhead

• 🟩 execution_time [-11.984ms; -9.469ms] or [-5.473%; -4.325%]

scenario:WordPressBench/benchWordPressOverhead-opcache

• 🟩 execution_time [-10.767ms; -8.338ms] or [-4.933%; -3.821%]

[pr-commenter[bot]]

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-06 17:37:19

Comparing candidate commit b30d87e9567628634dd250a313b3481ecaaa2c45 in PR branch glopes/waf-telemetry with baseline commit 196c7f271e33a6d4df5ac65e20125955f67ef5fc in branch master.

Found 3 performance improvements and 2 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

• 🟥 execution_time [+1.313µs; +2.887µs] or [+2.759%; +6.065%]

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-15.216µs; -10.878µs] or [-7.935%; -5.673%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-17.148µs; -9.187µs] or [-8.994%; -4.819%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 execution_time [+194.825ns; +678.175ns] or [+2.834%; +9.865%]

scenario:TraceFlushBench/benchFlushTrace

• 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

[pr-commenter[bot]]

Benchmarks [ appsec ]

Benchmark execution time: 2024-12-06 17:47:06

Comparing candidate commit b30d87e9567628634dd250a313b3481ecaaa2c45 in PR branch glopes/waf-telemetry with baseline commit 196c7f271e33a6d4df5ac65e20125955f67ef5fc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.