dd-trace-php
dd-trace-php copied to clipboard
Fix global priority sampling
The global priority sampling was not recognized as explicit sampling and thus ignored.
Benchmarks
Benchmark execution time: 2024-07-15 18:13:41
Comparing candidate commit 2999e5cb0936c1d377bb99083c9b0274c47e2a70 in PR branch bob/fix-global-priority-sampling with baseline commit 4c3832dd87909e43748538f72a40f0b4db690c1a in branch master.
Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.
scenario:PDOBench/benchPDOOverhead
- 🟥
execution_time[+9.861µs; +16.238µs] or [+3.615%; +5.953%]
scenario:PDOBench/benchPDOOverheadWithDBM
- 🟥
execution_time[+10.665µs; +16.878µs] or [+3.586%; +5.675%]
scenario:TraceSerializationBench/benchSerializeTrace
- 🟩
execution_time[-9.918µs; -6.582µs] or [-4.995%; -3.315%]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.96%. Comparing base (
4c3832d) to head (2999e5c).
Additional details and impacted files
@@ Coverage Diff @@
## master #2728 +/- ##
=========================================
Coverage 77.96% 77.96%
Complexity 2216 2216
=========================================
Files 227 227
Lines 26643 26644 +1
Branches 989 989
=========================================
+ Hits 20771 20772 +1
Misses 5346 5346
Partials 526 526
| Flag | Coverage Δ | |
|---|---|---|
| appsec-extension | 69.19% <ø> (ø) |
|
| tracer-extension | 78.81% <100.00%> (+<0.01%) |
:arrow_up: |
| tracer-php | 80.55% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| ext/serializer.c | 81.27% <100.00%> (+0.01%) |
:arrow_up: |
| src/DDTrace/Span.php | 79.45% <100.00%> (ø) |
|
| src/DDTrace/Tracer.php | 82.43% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4c3832d...2999e5c. Read the comment docs.