dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Make generators replaceable

Open bwoebi opened this issue 1 year ago • 2 comments
trafficstars

Required for the PHP 8.1+ OpenAI integration.

bwoebi avatar Jun 17 '24 15:06 bwoebi

Codecov Report

:x: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 77.96%. Comparing base (4c3832d) to head (ea45a3d). :warning: Report is 728 commits behind head on master.

Files with missing lines Patch % Lines
..._abstract_interface/interceptor/php8/interceptor.c 82.69% 9 Missing :warning:

:x: Your patch status has failed because the patch coverage (83.92%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2718   +/-   ##
=========================================
  Coverage     77.96%   77.96%           
  Complexity     2216     2216           
=========================================
  Files           227      227           
  Lines         26643    26694   +51     
  Branches        989      989           
=========================================
+ Hits          20771    20813   +42     
- Misses         5346     5355    +9     
  Partials        526      526           
Flag Coverage Δ
appsec-extension 69.19% <ø> (ø)
tracer-extension 78.82% <83.92%> (+0.01%) :arrow_up:
tracer-php 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/hook/uhook.c 84.72% <100.00%> (+0.11%) :arrow_up:
..._abstract_interface/interceptor/php8/interceptor.c 77.80% <82.69%> (+0.37%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c3832d...ea45a3d. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jun 17 '24 15:06 codecov-commenter

Benchmarks

Benchmark execution time: 2024-07-16 13:11:39

Comparing candidate commit ea45a3d6d4e97bef5d120bf3325fa7e4fde108e2 in PR branch bob/support-replace-generator with baseline commit 4c3832dd87909e43748538f72a40f0b4db690c1a in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟥 execution_time [+56.828µs; +163.812µs] or [+2.167%; +6.246%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+4.151µs; +14.031µs] or [+2.406%; +8.131%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟩 execution_time [-437.795ns; -256.005ns] or [-6.374%; -3.727%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-463.626ns; -144.374ns] or [-6.652%; -2.071%]

pr-commenter[bot] avatar Jun 17 '24 16:06 pr-commenter[bot]