dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Add path to Symfony Route defaults

Open estringana opened this issue 1 year ago • 2 comments

Description

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [ ] Appropriate labels assigned.

estringana avatar Mar 21 '24 16:03 estringana

Benchmarks

Benchmark execution time: 2024-03-27 08:56:12

Comparing candidate commit 7c6b6c7a90ea2ed06ab5dff60129241dffee8741 in PR branch estringana/cache-symfony-path with baseline commit 7eb4638cbe539f7095e761bc91bed682c3760edb in branch master.

Found 1 performance improvements and 4 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

  • 🟩 execution_time [-145.563ns; -118.637ns] or [-8.589%; -7.000%]

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

  • 🟥 execution_time [+218.135ns; +449.265ns] or [+2.404%; +4.951%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+5.700µs; +8.316µs] or [+2.036%; +2.971%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+10.440µs; +12.535µs] or [+3.428%; +4.115%]
  • 🟥 mem_peak [+99.680KB; +99.680KB] or [+4.422%; +4.422%]

pr-commenter[bot] avatar Mar 21 '24 17:03 pr-commenter[bot]

Codecov Report

Merging #2590 (7c6b6c7) into master (7eb4638) will decrease coverage by 14.18%. Report is 19 commits behind head on master. The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2590       +/-   ##
=============================================
- Coverage     77.07%   62.90%   -14.18%     
  Complexity     2563     2563               
=============================================
  Files           215      215               
  Lines         23048    23061       +13     
=============================================
- Hits          17765    14507     -3258     
- Misses         5283     8554     +3271     
Flag Coverage Δ
tracer-extension 78.70% <ø> (ø)
tracer-php 43.36% <0.00%> (-31.70%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ations/Integrations/Symfony/SymfonyIntegration.php 0.00% <0.00%> (-83.29%) :arrow_down:

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7eb4638...7c6b6c7. Read the comment docs.

codecov-commenter avatar Mar 22 '24 11:03 codecov-commenter