Remove deprecated configuration keys or APIs

[PROFeNoM]

trafficstars

Description

APIs

• dd_trace_forward_call
• dd_trace_generate_id
• dd_trace_push_span_id
• dd_trace_pop_span_id
• additional_trace_meta
• Everything that is circuit-breaker-related
  • dd_tracer_circuit_breaker_register_error
  • dd_tracer_circuit_breaker_register_success
  • dd_tracer_circuit_breaker_can_try
  • dd_tracer_circuit_breaker_info
• Everything that may have been marked as @deprecated in the "Legacy PHP API"

Config Knobs

• DD_INTEGRATIONS_DISABLED → DD_TRACE_[INTEGRATION]_ENABLE=false
• ~DDTRACE_REQUEST_INIT_HOOK → DD_TRACE_REQUEST_INIT_HOOK~
• DD_SERVICE_NAME → DD_SERVICE
• DD_TRACE_GLOBAL_TAGS → DD_TAGS
• DD_TRACE_APP_NAME → DD_SERVICE
• ddtrace_app_name → DD_SERVICE
• DD_TRACE_RESOURCE_URI_MAPPING → DD_TRACE_RESOURCE_URI_MAPPING_INCOMING and DD_TRACE_RESOURCE_URI_MAPPING_OUTGOING
• DD_SAMPLING_RATE → DD_TRACE_SAMPLE_RATE
• DD_PROPAGATION_STYLE_INJECT → DD_TRACE_PROPAGATION_STYLE_INJECT
• DD_PROPAGATION_STYLE_EXTRACT → DD_TRACE_PROPAGATION_STYLE_EXTRACT
• Everything that is circuit-breaker-related
  • DD_TRACE_AGENT_MAX_CONSECUTIVE_FAILURES
  • DD_TRACE_CIRCUIT_BREAKER_DEFAULT_MAX_CONSECUTIVE_FAILURES
  • DD_TRACE_AGENT_ATTEMPT_RETRY_TIME_MSEC
  • DD_TRACE_CIRCUIT_BREAKER_DEFAULT_RETRY_TIME_MSEC

It also removes UPGRADE-0.10.md, Http.php (unused), and circuit breaker code.

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-03-08 15:28:20

Comparing candidate commit 051314ade81d3b4a7dea0c064210d6502dcd4e8f in PR branch alex/remove/env_api with baseline commit c3ba15e5e6f9a698c9336b191d1501e5d0e1ac2b in branch ddtrace-1.0.0.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

[codecov-commenter]

Codecov Report

Merging #2554 (051314a) into ddtrace-1.0.0 (c3ba15e) will increase coverage by 10.92%. Report is 1 commits behind head on ddtrace-1.0.0. The diff coverage is 66.66%.

Additional details and impacted files

@@                 Coverage Diff                  @@
##             ddtrace-1.0.0    #2554       +/-   ##
====================================================
+ Coverage            67.33%   78.25%   +10.92%     
+ Complexity            2327     2314       -13     
====================================================
  Files                  228      200       -28     
  Lines                26096    21963     -4133     
  Branches               976        0      -976     
====================================================
- Hits                 17571    17188      -383     
+ Misses                8005     4775     -3230     
+ Partials               520        0      -520     

Flag	Coverage Δ
appsec-extension	?
tracer-extension	78.50% <100.00%> (-0.01%)	:arrow_down:
tracer-php	77.91% <0.00%> (+26.91%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ext/coms.c	79.69% <ø> (ø)
ext/coms.h	100.00% <ø> (ø)
ext/configuration.c	77.96% <100.00%> (+4.11%)	:arrow_up:
ext/configuration.h	100.00% <ø> (ø)
ext/ddtrace.c	73.48% <ø> (+0.14%)	:arrow_up:
ext/ddtrace_arginfo.h	100.00% <ø> (ø)
ext/startup_logging.c	86.93% <ø> (-2.34%)	:arrow_down:
src/DDTrace/OpenTracer/Scope.php	100.00% <ø> (ø)
src/DDTrace/OpenTracer/ScopeManager.php	88.23% <ø> (ø)
src/DDTrace/OpenTracer/Span.php	63.33% <ø> (ø)
... and 12 more

... and 43 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3ba15e...051314a. Read the comment docs.

[PROFeNoM]

Superseded by #2574