dd-trace-php
dd-trace-php copied to clipboard
feat(profiling) report PHP flavour (`NTS` vs `ZTS`)
Description
PROF-9204 / #2070
This PR will add the PHP flavour (ZTS vs NTS) as a tag (runtime_engine) to the profiles.
Reviewer checklist
- [x] Test coverage seems ok.
- [x] Appropriate labels assigned.
Benchmarks
Benchmark execution time: 2024-03-08 13:57:08
Comparing candidate commit 901496ccb92b72e7f7adc49bc7ae8403917ec02b in PR branch florian/tag-zts with baseline commit 2e1ed1246c52d0330099cf1b9a849ac6d5c762f8 in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.
Codecov Report
Merging #2536 (5bdf2b2) into master (ab2dd7d) will increase coverage by
2.19%. Report is 2 commits behind head on master. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## master #2536 +/- ##
============================================
+ Coverage 76.55% 78.74% +2.19%
Complexity 267 267
============================================
Files 138 112 -26
Lines 17459 13485 -3974
Branches 976 0 -976
============================================
- Hits 13365 10619 -2746
+ Misses 3574 2866 -708
+ Partials 520 0 -520
| Flag | Coverage Δ | |
|---|---|---|
| appsec-extension | ? |
|
| tracer-extension | 78.70% <ø> (ø) |
|
| tracer-integrations | 79.49% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 26 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ab2dd7d...5bdf2b2. Read the comment docs.