dd-trace-php
dd-trace-php copied to clipboard
CodeIgniter 3 Compatibility
Description
Add the CodeIgniter 3 test suite, and allow the integration to be used with this version since it is seemingly compatible with it.
Reviewer checklist
- [ ] Test coverage seems ok.
- [ ] Appropriate labels assigned.
Benchmarks
Benchmark execution time: 2024-04-02 13:24:59
Comparing candidate commit 0968e64ba10aabb7c29a57b043236f1e53a97d59 in PR branch alex/feat/codeigniter-testsuite with baseline commit e670e76d606fc31985d50a091ff5a6d7f69ed86d in branch master.
Found 0 performance improvements and 2 performance regressions! Performance is the same for 180 metrics, 0 unstable metrics.
scenario:ContextPropagationBench/benchInject64Bit-opcache
- 🟥
execution_time[+147.578ns; +806.422ns] or [+2.048%; +11.189%]
scenario:SpanBench/benchOpenTelemetryInteroperability-opcache
- 🟥
execution_time[+17.686µs; +45.153µs] or [+2.491%; +6.360%]
On-hold. See bcit-ci/CodeIgniter#6267
Codecov Report
Merging #2515 (0968e64) into master (e670e76) will not change coverage. Report is 3 commits behind head on master. The diff coverage is
100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2515 +/- ##
=========================================
Coverage 76.53% 76.53%
- Complexity 2607 2609 +2
=========================================
Files 217 217
Lines 23318 23318
=========================================
Hits 17846 17846
Misses 5472 5472
| Flag | Coverage Δ | |
|---|---|---|
| tracer-extension | 78.70% <ø> (ø) |
|
| tracer-php | 73.86% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| ...grations/CodeIgniter/V2/CodeIgniterIntegration.php | 50.64% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update e670e76...0968e64. Read the comment docs.