dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Laravel integration - Add APM span tracking

Open ramasofficial opened this issue 3 years ago • 1 comments

Description

Readiness checklist

  • [ ] (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • [ ] Appropriate labels assigned.
  • [ ] Milestone is set.
  • [ ] Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

ramasofficial avatar Aug 10 '22 07:08 ramasofficial

Hey @ramasofficial, thanks a lot for the contribution!

Would you mind adding tests for it? Our laravel integration tests reside in https://github.com/DataDog/dd-trace-php/tree/master/tests/Integrations/Laravel.

To run the tests, in the root of the repository, spin up the container via docker-compose run --rm 7.1-buster bash (for older laravel versions) or docker-compose run --rm 8.1-buster bash for the current laravel version, then do make test_web_laravel_42 (or make test_web_laravel_57, make test_web_laravel_58 or make test_web_laravel_8x).

Thanks!

bwoebi avatar Aug 10 '22 15:08 bwoebi

We're tracking laravel queues as of 0.87.0 now, thus closing this PR :-)

bwoebi avatar May 12 '23 11:05 bwoebi