dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

"Cannot open request init hook" should not be logged as debug

Open gnumoksha opened this issue 3 years ago • 2 comments

It seems to be an error, isn't it?

https://github.com/DataDog/dd-trace-php/blob/a219e080bb1333b0a2d3ec14003100d9a2c8f4a4/ext/php7/request_hooks.c#L133

gnumoksha avatar Jun 21 '21 17:06 gnumoksha

Thank you for the feature request @gnumoksha. At the moment the tracer does not support log levels so all messages are logged when DD_TRACE_DEBUG=1. I cannot provide an ETA for adding log levels, but we do plan to support log levels in a future release and this message would certainly classify as an error-level message.

SammyK avatar Jun 25 '21 21:06 SammyK

Ok. It would be nice to describe on the documentation that DD_TRACE_DEBUG also turns on error logs

gnumoksha avatar Jun 28 '21 12:06 gnumoksha