dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

fix(service-bus) Fix synchronous shimming of tryAddMessage

Open jcstorms1 opened this issue 1 week ago • 3 comments

What does this PR do?

Changes the shim of tryAddMessage to use traceSync instead of tracePromise.

Motivation

The method returns a boolean and not a promise.

A customer opened a PR with a fix but the commits were unsigned

Plugin Checklist

Additional Notes

jcstorms1 avatar Dec 12 '25 16:12 jcstorms1

Overall package size

Self size: 4.34 MB Deduped: 5.22 MB No deduping: 5.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95c3c60 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 84.76%. Comparing base (e9493e1) to head (95c3c60).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7098      +/-   ##
==========================================
+ Coverage   84.63%   84.76%   +0.12%     
==========================================
  Files         515      521       +6     
  Lines       21994    22151     +157     
==========================================
+ Hits        18615    18776     +161     
+ Misses       3379     3375       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 12 '25 16:12 codecov[bot]

nit: we usually try to cherrypick the commits from the original authors, when recreating externally contributed PRs, to retain authorship credit where it's due!

simon-id avatar Dec 14 '25 11:12 simon-id

Benchmarks

Benchmark execution time: 2025-12-16 21:18:16

Comparing candidate commit 95c3c601d3f18ffea2642e59188897cfa7f90f52 in PR branch storms/fix-azure-service-bus-try-add-message with baseline commit e9493e1923fac4cc2b0325e0b5d413ad00fc7cf3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics.

pr-commenter[bot] avatar Dec 15 '25 14:12 pr-commenter[bot]

nit: we usually try to cherrypick the commits from the original authors, when recreating externally contributed PRs, to retain authorship credit where it's due!

@simon-id thanks for comment. I wanted to clarify that I did try to cherry-pick but the PR was force-pushed and I was unable to get the revision history since I didn't have it locally. I will make sure to do this moving forward.

jcstorms1 avatar Dec 15 '25 14:12 jcstorms1