dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

fix: Stop using Azure's EventHubs batch spanContext map for storing DD span contexts

Open jcstorms1 opened this issue 1 month ago • 4 comments

What does this PR do?

  • Stores our span contexts in a weakMap

Motivation

Originally we used Azure's built in spanContext map to store span context for our span links. This could cause conflicts with Azure Application Inights if OTel is enabled, because Azure uses this map to generate their span links.

Plugin Checklist

Additional Notes

jcstorms1 avatar Nov 18 '25 19:11 jcstorms1

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 84.48%. Comparing base (b00ab50) to head (95dbbb4). :warning: Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6943      +/-   ##
==========================================
- Coverage   84.49%   84.48%   -0.01%     
==========================================
  Files         523      523              
  Lines       22447    22448       +1     
==========================================
  Hits        18966    18966              
- Misses       3481     3482       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 18 '25 19:11 codecov[bot]

Overall package size

Self size: 4.39 MB Deduped: 5.21 MB No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Nov 18 '25 19:11 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-12-22 18:40:34

Comparing candidate commit 95dbbb41b4215eb954ee1dbd4f7aa9ffc4a8c08f in PR branch storms/refactor-event-hubs-batch-contexts with baseline commit b00ab5001877f2142c405f9ed5812e07f6e1772a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

pr-commenter[bot] avatar Nov 21 '25 15:11 pr-commenter[bot]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95dbbb4 | Docs | Datadog PR Page | Was this helpful? Give us feedback!