dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard
verified publisher icon DataDog

Crysmags/ws integration

Open crysmags opened this issue 6 months ago • 4 comments

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

crysmags avatar Jun 05 '25 13:06 crysmags

Overall package size

Self size: 12.01 MB Deduped: 112.09 MB No deduping: 112.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.10.0 | 9.91 MB | 10.3 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Jun 05 '25 13:06 github-actions[bot]

Codecov Report

:x: Patch coverage is 81.08108% with 28 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 84.27%. Comparing base (e6dcda4) to head (87b70aa). :warning: Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...d-trace/src/service-naming/schemas/v0/websocket.js 20.00% 8 Missing :warning:
packages/datadog-plugin-ws/src/close.js 75.86% 7 Missing :warning:
packages/datadog-plugin-ws/src/server.js 88.23% 4 Missing :warning:
packages/datadog-plugin-ws/src/producer.js 87.50% 3 Missing :warning:
...ages/datadog-instrumentations/src/helpers/hooks.js 0.00% 2 Missing :warning:
packages/datadog-plugin-ws/src/receiver.js 92.59% 2 Missing :warning:
packages/dd-trace/src/plugins/index.js 0.00% 2 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
- Coverage   84.31%   84.27%   -0.04%     
==========================================
  Files         477      479       +2     
  Lines       20086    20188     +102     
==========================================
+ Hits        16936    17014      +78     
- Misses       3150     3174      +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 05 '25 13:06 codecov[bot]

Benchmarks

Benchmark execution time: 2025-09-09 16:47:30

Comparing candidate commit 87b70aaaaa117113bbabd9801351074001a5dd7c in PR branch crysmags/ws-integration with baseline commit e6dcda432ccfc8a5b10a16b96c7fc69aeb5eb0b8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1684 metrics, 80 unstable metrics.

pr-commenter[bot] avatar Jun 05 '25 13:06 pr-commenter[bot]

Datadog Report

Branch report: crysmags/ws-integration Commit report: 39c5ff9 Test service: dd-trace-js-integration-tests

:white_check_mark: 0 Failed, 1260 Passed, 0 Skipped, 22m 7.6s Total Time

datadog-datadog-prod-us1[bot] avatar Jun 05 '25 14:06 datadog-datadog-prod-us1[bot]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 87b70aa | Docs | Was this helpful? Give us feedback!

datadog-datadog-prod-us1[bot] avatar Jul 25 '25 14:07 datadog-datadog-prod-us1[bot]

Rebasing on master and force-pushing

tlhunter avatar Aug 20 '25 22:08 tlhunter

The remaining errors seem to all be related to selenium. Wouldn't you know it, selenium depends on ws.

It might be that we're now instrumenting the ws used by selenium which is then breaking tests which rely on specific span data being produced. Or it could mean that we fundamentally broke ws. Maybe the latter since I can't imagine the selenium tests have this experimental integration enabled.

tlhunter avatar Aug 21 '25 02:08 tlhunter