dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

chore(tracing): remove async storage from mongo plugins

Open wconti27 opened this issue 5 months ago • 4 comments

What does this PR do?

Make mongo plugins Node 24 compatible

Motivation

Plugin Checklist

Additional Notes

wconti27 avatar Jun 03 '25 14:06 wconti27

Overall package size

Self size: 11.13 MB Deduped: 110.71 MB No deduping: 111.1 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.1 | 20.3 MB | 20.3 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Jun 03 '25 14:06 github-actions[bot]

Codecov Report

:x: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 83.12%. Comparing base (3e23304) to head (cce49fe). :warning: Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/mongoose.js 94.11% 1 Missing :warning:
packages/datadog-plugin-mongoose/src/index.js 87.50% 1 Missing :warning:
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5812   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         476      477    +1     
  Lines       19719    19727    +8     
=======================================
+ Hits        16392    16399    +7     
- Misses       3327     3328    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 03 '25 14:06 codecov[bot]

Benchmarks

Benchmark execution time: 2025-07-30 19:14:29

Comparing candidate commit cce49fe4a1704be0b98bc6d4527936eb5de892d8 in PR branch conti/remove-async-storage-mongo with baseline commit 3e233040f1dbb0104cec9311a3747b931ae4ae5a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1262 metrics, 61 unstable metrics.

pr-commenter[bot] avatar Jun 03 '25 14:06 pr-commenter[bot]

Datadog Report

Branch report: conti/remove-async-storage-mongo Commit report: 080e076 Test service: dd-trace-js-integration-tests

:white_check_mark: 0 Failed, 1254 Passed, 0 Skipped, 17m 19.36s Total Time

@wconti27 there seem to still be a few related test failures :)

https://github.com/DataDog/dd-trace-js/actions/runs/16173889662/job/45654105379?pr=5812

BridgeAR avatar Jul 10 '25 14:07 BridgeAR

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

[email protected] commonJS flaky test retries retries flaky tests from integration-tests/cypress/cypress.spec.js (Datadog)
expected +0 to equal 1

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cce49fe | Docs | Was this helpful? Give us feedback!