dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Migrating Tedious from Async Resource to runStores

Open crysmags opened this issue 6 months ago • 6 comments

What does this PR do?

Convert Tedious fromAsync Resource to runStores

Motivation

Async Resource no longer works as expected in Node 24.

crysmags avatar May 19 '25 16:05 crysmags

Overall package size

Self size: 9.64 MB Deduped: 106.64 MB No deduping: 107.16 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 9.0.0 | 19.6 MB | 19.61 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar May 19 '25 16:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.86%. Comparing base (bc0b431) to head (78e6fac). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5747      +/-   ##
==========================================
- Coverage   79.53%   78.86%   -0.67%     
==========================================
  Files         477      466      -11     
  Lines       20295    20093     -202     
==========================================
- Hits        16142    15847     -295     
- Misses       4153     4246      +93     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 19 '25 16:05 codecov[bot]

Datadog Report

Branch report: crysmags/support_node_24_db_sql Commit report: 6d4a0aa Test service: dd-trace-js-integration-tests

:white_check_mark: 0 Failed, 1259 Passed, 0 Skipped, 18m 39.86s Total Time :snowflake: 1 New Flaky

New Flaky Tests (1)

  • [email protected] commonJS flaky test retries retries flaky tests - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
    xpected +0 to equal 1
    

Benchmarks

Benchmark execution time: 2025-07-02 20:22:05

Comparing candidate commit 314df41e37e2aae3c94972fcf6f903af513c3da2 in PR branch crysmags/support_node_24_db_sql with baseline commit 24cbac1956fb9e6c6dd539ab024bd77e5123d971 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1270 metrics, 53 unstable metrics.

pr-commenter[bot] avatar May 20 '25 18:05 pr-commenter[bot]

/merge

crysmags avatar May 21 '25 21:05 crysmags

View all feedbacks in Devflow UI.

2025-05-21 21:51:30 UTC :information_source: Start processing command /merge


2025-05-21 21:51:38 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-05-22 01:52:09 UTC :warning: MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

dd-devflow[bot] avatar May 21 '25 21:05 dd-devflow[bot]