dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

CI: Configure supported Node.js version range using repository variables

Open watson opened this issue 8 months ago • 5 comments
trafficstars

What does this PR do?

Configure supported Node.js version range using repository variables

Currently, the following repository variables are created:

  • ACTIVE_LTS (set to 22 as of this commit)
  • NESTEST_MAINTENANCE_LTS (set to 20 as of this commit)
  • OLDEST_MAINTENANCE_LTS (set to 18 as of this commit)

Motivation

Make it easier to upgrade to newer major Node.js versions when they are released.

watson avatar Feb 26 '25 12:02 watson

This stack of pull requests is managed by Graphite. Learn more about stacking.

watson avatar Feb 26 '25 12:02 watson

Datadog Report

Branch report: watson/clean-up-gh-action-node-install2 Commit report: 15293bf Test service: dd-trace-js-integration-tests

:white_check_mark: 0 Failed, 65 Passed, 0 Skipped, 0s Total Time

Benchmarks

Benchmark execution time: 2025-02-27 05:03:49

Comparing candidate commit 0b5e37693bc234eabe7c0cb8dd94e20e9b9c082a in PR branch watson/clean-up-gh-action-node-install2 with baseline commit 9bc5d3440a462ecb3f7287f5b0d1afb021e4143b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

pr-commenter[bot] avatar Feb 26 '25 12:02 pr-commenter[bot]

Overall package size

Self size: 8.8 MB Deduped: 95 MB No deduping: 95.52 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Feb 26 '25 12:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (9bc5d34) to head (0b5e376). Report is 471 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #5323       +/-   ##
==========================================
- Coverage   80.70%       0   -80.71%     
==========================================
  Files         485       0      -485     
  Lines       21811       0    -21811     
==========================================
- Hits        17602       0    -17602     
+ Misses       4209       0     -4209     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 26 '25 12:02 codecov[bot]

I believe we managed this in an similar but alternative approach. I'll close this due to the number of conflicts, as it likely would need to be recreated anyway.

BridgeAR avatar Jul 08 '25 00:07 BridgeAR