dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

[BUG]: Requests and APM metrics zero-ing out with just a dd-trace upgrade 5.24.0 -> 5.35.0

Open TREFZ opened this issue 1 year ago • 7 comments

Tracer Version(s)

5.35.0

Node.js Version(s)

22.11.0

Bug Report

For our Node application, we pin dd-trace just to the major version, specifically v5. As part of a routine package-lock.json regeneration, our dd-trace version was bumped from 5.24.0 to 5.35.0. Immediately after release, our Datadog monitors for low request rates went off, showing that requests and all APM metrics were zero-ing out. But by all other monitoring, the website powered by this application was fine. The application was clearly responding to requests, and all traffic was normal.

On closer inspection of the released pull requests, we noted the upgrade in dd-trace, and maybe more importantly a major version upgrade to dd-trace's dependency @datadog/native-metrics. We can't say for sure if that was the cause, but after rolling back these changes, all Datadog activity returned to normal. For now, we've pinned our dd-trace version exactly to 5.24.0.

Shown below is our requests, segmented by release:

light blue = dd-trace 5.24.0 dark blue = dd-trace 5.35.0 upgrade, requests fall off a cliff purple = back to dd-trace 5.24.0, requests return to normal

Image

Reproduction Code

No response

Error Logs

No response

Tracer Config

tracer.init({
  logInjection: true,
  runtimeMetrics: true,
  version: <release version>
});

Operating System

GNU/Linux

Bundling

No Bundling

TREFZ avatar Feb 11 '25 21:02 TREFZ

Same for us.

upgrade to v5.37.1 seam to solve the problem

fabienlege avatar Feb 20 '25 19:02 fabienlege

Same problem, dd-trace 5.24.0 work fine, 5.31.0+ stop working, but with the plugin amqplib, basic.get resources.

marlonrosa avatar Mar 11 '25 14:03 marlonrosa

Is this still an issue with newer versions (5.50.0 and above)? If yes, please reach out to our support https://www.datadoghq.com/support/. They will prioritize looking into this in that case! We can't sadly provide such support through github.

BridgeAR avatar May 08 '25 19:05 BridgeAR

@BridgeAR I'll give an upgrade a try tomorrow morning and report back.

TREFZ avatar May 08 '25 22:05 TREFZ

Thank you very much @TREFZ !

BridgeAR avatar May 09 '25 10:05 BridgeAR

@BridgeAR So far, request rate seems stable. However all of our runtime metrics seem to have bottomed out, which is unusual for our releases, and we can't yet explain why we're seeing this.

Image

TREFZ avatar May 09 '25 14:05 TREFZ

@BridgeAR Here's an updated look at our Nodejs runtime metrics before and after upgrading our version of dd-trace from v5.24 to v5.51. Any idea why we'd be seeing such significant changes? Image

TREFZ avatar May 22 '25 20:05 TREFZ

Same problem with update from 5.49.0 to 5.59.0. All custom metrics go to zero. I've opened a ticket for the datadog support team.

antonio-masotti avatar Jul 18 '25 14:07 antonio-masotti

We're having the same problem in our team, we've been postponing the upgrade for several versions now, that we're currently stuck on 5.44.0 due to this. @antonio-masotti any luck with their support ?

nunomarks avatar Aug 01 '25 07:08 nunomarks