Add support for Azure App Services tags in profiler

[szegedi]

What does this PR do?

Ensures the profiler adds Windows Azure App Services-specific tags to profiles when app is running with Datadog APM Extensions for Windows Azure App Services.

Motivation

It's the right thing to do.

Additional Notes

Jira ticket: PROF-10738

[github-actions[bot]]

Overall package size

Self size: 7.58 MB Deduped: 62.31 MB No deduping: 62.59 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-10-21 20:16:38

Comparing candidate commit bbee172541c5f63a2213cb8bdd1a5c2610bc4455 in PR branch szegedi/azure-profiler-tags with baseline commit f8515ec28b0448da3e1963646235c9170679966b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

[duncanpharvey]

Upon further review I think we should be using these tags for Azure Container App profile billing. And if we can do it from the agent side then other runtimes can have the same behavior.

https://github.com/DataDog/datadog-agent/blob/1c49cec65124440006c89c5efaf5071f623a46f1/cmd/serverless-init/cloudservice/containerapp.go#L59-L69

[szegedi]

Hey @duncanpharvey, thanks for surfacing this – indeed significantly looking – distinction between Azure App Services and Azure Container Apps. I do think this PR is still valid, as it does fill a feature gap – with it, Node.js profiler will be at parity with libdatadog in Azure App Services support. I agree that we might need to separately support (and hopefully in the agent) the Azure Container Apps use case.

[duncanpharvey]

Hey @duncanpharvey, thanks for surfacing this – indeed significantly looking – distinction between Azure App Services and Azure Container Apps. I do think this PR is still valid, as it does fill a feature gap – with it, Node.js profiler will be at parity with libdatadog in Azure App Services support. I agree that we might need to separately support (and hopefully in the agent) the Azure Container Apps use case.

That makes sense! I see that the Azure App Services metadata is already added in the Java and .NET Tracers so to be consistent it should be here as well. Azure Container App metadata can be handled in a separate PR.