dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

modernize eslint config

Open bengl opened this issue 1 year ago • 3 comments

What does this PR do?

  • Switch from the old eslintrc format to the newer format via: npx @eslint/migrate-config .eslintrc.json
  • ECMAScript version is now set at 2022, in line with code supported in Node.js 16. This is needed for a bunch of ESM syntax like top-level await.
  • Fixes:
    • ESM files are now covered.
    • Test globals and other test-specific config are now isolated to tests.
    • text_map.js has an invalid switch case. Fixed that in what I thought was the most reasonable way.

Motivation

I was trying to add new local lint rules, but that's only supported by the modern config format. Along the way I noticed we weren't covering ESM files at all.

bengl avatar Oct 03 '24 21:10 bengl

Overall package size

Self size: 8.23 MB Deduped: 94.73 MB No deduping: 95.29 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Oct 03 '24 21:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-12-05 21:07:43

Comparing candidate commit 57ad6500d4c4dcebab3eab1f8945c0324f1a443d in PR branch bengl/modernize-eslint with baseline commit 66ac25add84a3260263e1f1d7cf94577851f8e13 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 263 metrics, 3 unstable metrics.

pr-commenter[bot] avatar Oct 03 '24 21:10 pr-commenter[bot]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (bb0bbcc) to head (c8e8ac3). Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...s/dd-trace/src/opentracing/propagation/text_map.js 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
- Coverage   91.42%   83.93%   -7.49%     
==========================================
  Files         112      292     +180     
  Lines        3475    12078    +8603     
  Branches       33       33              
==========================================
+ Hits         3177    10138    +6961     
- Misses        298     1940    +1642     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 17:10 codecov[bot]