dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

kafkajs: support eachBatch consumer callback

Open wconti27 opened this issue 1 year ago • 3 comments

What does this PR do?

Adds support for KafkaJS batch consumes using eachBatch callback. Also adds an experimental batchedParentPropagationEnabled config for kafkajs that is disabled by defaut and enables parent-child propagation using the first valid trace context found within returned messages, including a matching env variable configuration of DD_TRACE_KAFKAJS_BATCHED_PARENT_PROPAGATION_ENABLED.

Motivation

Client FR

Plugin Checklist

Additional Notes

wconti27 avatar Aug 26 '24 16:08 wconti27

Overall package size

Self size: 7 MB Deduped: 58.22 MB No deduping: 58.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Aug 26 '24 16:08 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-08-28 15:21:21

Comparing candidate commit 29195eddc2c588b725edb4f127b30b12076c1bef in PR branch conti/kafkajs-batching-support with baseline commit 474a73573fa01bc0922203b804f219d886745c98 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

pr-commenter[bot] avatar Aug 26 '24 19:08 pr-commenter[bot]

I think this PR is missing a title?

watson avatar Aug 28 '24 14:08 watson

This pull request has been marked as stale due to 90 days of inactivity. If this is still relevant, please update or comment to keep it open. If this should be kept open indefinitely, please apply the label keep-open. Otherwise, it will be automatically closed after 14 days.

github-actions[bot] avatar Feb 20 '25 04:02 github-actions[bot]