dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

don't analyze destroyed responses

Open simon-id opened this issue 1 year ago • 2 comments

What does this PR do?

Motivation

TODO: test:

router.get('/wafcontext', (req, res) => {
  new Promise((resolve, reject) => {
    setTimeout(() => {
      reject('errrrrr')
    }, 5000)
  }).catch((err) => {
    res.status(500).json({ message: 'Error on request' + err })
  })
})

curl -m 1 -v http://localhost:3000/ssrf/wafcontext

simon-id avatar Aug 21 '24 09:08 simon-id

Overall package size

Self size: 6.98 MB Deduped: 58.2 MB No deduping: 58.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Aug 21 '24 09:08 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-08-21 09:45:35

Comparing candidate commit 97b9e95bbcaed96d3f07deb436d3c8525e8a7fa5 in PR branch simon-id/fix_response_destroyed with baseline commit 4df8c4daa7201dde7405aa03b4d64a7f49928223 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

pr-commenter[bot] avatar Aug 21 '24 09:08 pr-commenter[bot]

Closed in favour of https://github.com/DataDog/dd-trace-js/pull/4653

CarlesDD avatar Sep 06 '24 08:09 CarlesDD