dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

fix(lambda): gate timeout spans and add missing clear

Open duncanista opened this issue 1 year ago • 2 comments

What does this PR do?

Gates AWS Lambda tracer instrumentation with the key lambda. Adds a clearTimeout to non-promisified functions.

Motivation

Support ticket where customers was being timed out because they were using promises and returning the function as non-promisified, making it to successfully work with AWS Lambda, but not with our tracer instrumentation.

Plugin Checklist

Additional Notes

Disabled by DD_TRACE_DISABLED_INSTRUMENTATIONS=lambda,other,another by following the current workaround for instrumentations.

duncanista avatar Jun 27 '24 19:06 duncanista

Overall package size

Self size: 6.85 MB Deduped: 58.36 MB No deduping: 58.64 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 6.56 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Jun 27 '24 19:06 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-07-22 04:15:44

Comparing candidate commit 43421df2f042a24a4ea1eb37794026b218662fa1 in PR branch jordan.gonzalez/lambda/gate-and-clear-timeout-on-result with baseline commit 1cf552f57316613560993a28c4e7db8747f6f559 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

pr-commenter[bot] avatar Jun 27 '24 19:06 pr-commenter[bot]