dd-trace-js
dd-trace-js copied to clipboard
cache next apps
What does this PR do?
Cache next apps generated for tests, only in CI. For now, only for the plugin tests, though this technique can be re-used in the future for integration tests.
Motivation
The building of next apps takes a long time in CI. Not building them is a good thing.
Numbers
Before (6m 13s) https://github.com/DataDog/dd-trace-js/actions/runs/9324282222/job/25669256544 After (4m 56s) https://github.com/DataDog/dd-trace-js/actions/runs/9352337264/job/25740495900
Okay, maybe this isn't as big a win?
Overall package size
Self size: 6.59 MB Deduped: 61.85 MB No deduping: 62.13 MB
Dependency sizes
| name | version | self size | total size |
|---|---|---|---|
| @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB |
| @datadog/native-iast-taint-tracking | 2.1.0 | 14.91 MB | 14.92 MB |
| @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB |
| protobufjs | 7.2.5 | 2.77 MB | 6.56 MB |
| @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB |
| @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB |
| @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB |
| @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB |
| import-in-the-middle | 1.7.4 | 70.19 kB | 739.86 kB |
| msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB |
| opentracing | 0.14.7 | 194.81 kB | 194.81 kB |
| semver | 7.5.4 | 93.4 kB | 123.8 kB |
| pprof-format | 2.1.0 | 111.69 kB | 111.69 kB |
| @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB |
| lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB |
| lru-cache | 7.14.0 | 74.95 kB | 74.95 kB |
| ignore | 5.2.4 | 51.22 kB | 51.22 kB |
| int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB |
| shell-quote | 1.8.1 | 44.96 kB | 44.96 kB |
| istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB |
| tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB |
| limiter | 1.1.5 | 23.17 kB | 23.17 kB |
| dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB |
| retry | 0.13.1 | 18.85 kB | 18.85 kB |
| jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB |
| crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB |
| path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB |
| koalas | 1.0.2 | 6.47 kB | 6.47 kB |
| module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |
🤖 This report was automatically generated by heaviest-objects-in-the-universe
Benchmarks
Benchmark execution time: 2024-06-03 15:01:30
Comparing candidate commit 8883de8671524d7b94aa8b8dbc6f4c158fd09bee in PR branch bengl/cache-next-apps with baseline commit 60f10dd07f82a992a49bd3c0e13340bd1ffdf970 in branch master.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.
scenario:plugin-graphql-with-depth-on-max-18
- 🟩
max_rss_usage[-120.121MB; -110.635MB] or [-12.391%; -11.413%]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.93%. Comparing base (
60f10dd) to head (32352b8).
:exclamation: Current head 32352b8 differs from pull request most recent head 8883de8
Please upload reports for the commit 8883de8 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #4368 +/- ##
==========================================
- Coverage 85.01% 84.93% -0.08%
==========================================
Files 257 256 -1
Lines 11361 11252 -109
Branches 33 33
==========================================
- Hits 9658 9557 -101
+ Misses 1703 1695 -8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.