dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

allow reconfiguration via init()

Open bengl opened this issue 1 year ago • 2 comments

What does this PR do?

Every time init() is called, pass the options object to .configure(), allowing for config to be changed at any time (as it already can be with remote config).

Motivation

This allows programmatic config to apply even if -r dd-trace/init was used.

bengl avatar May 08 '24 20:05 bengl

Overall package size

Self size: 6.48 MB Deduped: 60.62 MB No deduping: 60.9 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar May 08 '24 20:05 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-05-20 14:28:41

Comparing candidate commit eff6c2707fff7b72071e8a703d2456665b31c307 in PR branch bengl/init-as-configure with baseline commit f4adddc8086e628753fc3499c8b5faf104966b34 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-114.929MB; -102.379MB] or [-12.202%; -10.869%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-149.439MB; -112.885MB] or [-15.562%; -11.755%]

pr-commenter[bot] avatar May 08 '24 20:05 pr-commenter[bot]

Gonna do something else here. This is too complicated.

bengl avatar Feb 19 '25 18:02 bengl